Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SerpApi Example #289

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Add SerpApi Example #289

merged 7 commits into from
Aug 2, 2023

Conversation

Zevleg
Copy link
Contributor

@Zevleg Zevleg commented Aug 1, 2023 •
edited
Loading

Ticket Implement Search API

Output result:

image

@Zevleg Zevleg requested a review from raulraja August 1, 2023 04:39
raulraja
raulraja requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think we should address the comments before merging so this class is consistent with how the other classes and services work with credentials, error handling, and names.

reasoning/src/commonMain/kotlin/com/xebia/functional/xef/reasoning/serpapi/SerpApiClient.kt Outdated Show resolved Hide resolved
reasoning/src/commonMain/kotlin/com/xebia/functional/xef/reasoning/serpapi/SerpApiClient.kt Outdated Show resolved Hide resolved
reasoning/src/commonMain/kotlin/com/xebia/functional/xef/reasoning/serpapi/SerpApiClient.kt Outdated Show resolved Hide resolved
reasoning/src/commonMain/kotlin/com/xebia/functional/xef/reasoning/serpapi/SerpApiClient.kt Outdated Show resolved Hide resolved
reasoning/src/commonMain/kotlin/com/xebia/functional/xef/reasoning/serpapi/SerpApiClient.kt Outdated Show resolved Hide resolved
raulraja
raulraja previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, added a final comment to ensure it autocloses

raulraja
raulraja approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @Zevleg !

@raulraja raulraja merged commit e4c28d7 into main Aug 2, 2023
@raulraja raulraja deleted the search_api branch August 2, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zevleg @raulraja