Expose docker-compose up --build flag #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Hah; I had this exact same change queued up in my local master, but forgot about committing it! |
|
To add to the confusion @dylanscott, various minor versions of Docker Compose have temporarily removed one or the other of these flags. Before I added the "don't specify defaulted options" logic -- ugly though it is in our Ruby codebase -- this was a huge problem. With the non-defaulting in place, we can support the union of all CLI parameters that any version of Compose has ever supported. I'm going to publish v1.0.0 with your changes. I've been using the pre-release for several weeks now and haven't encountered any troubles; this was the last item on my list. Thanks for the contribution. |
|
Awesome, thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: This PR adds a parameter to
Docker::Compose::Session'supmethod to pass the--buildflag todocker-compose.Long version: There seems to be some long and confusing (at least to me) history with these flags, and despite their names they are not inverses of one another. It appears that way back in the day (when
docker-composewasfig) the default behavior was to build images before starting containers, so a--no-buildflag was added to speed up the command by suppressing this behavior. Later, the default behavior was changed and the--buildflag was added to force a build.