Multiple sp same entityid solution #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minimal change required to provide at least the possibility of supporting multiple SP entries with the same entity id.
It's required specifically to support multiple integrations with AWS services which all use th same entity_id, but it's not possible (or logical) to create multiple ServiceProvider instances with the same entity-id. So the solution is to add an extra field in an overridden ServiceProvider instance e.g. real_entity_id which takes precedence if provided:
def get_entity_id(self):
return self.real_entity_id or self.entity_id
The entity_id field can then be used as a lookup/alias field, e.g:
/idp/sso/init?sp=aws-quicksight
/idp/sso/init?sp=aws-appstream
For each ServiceProvider instance the entity_id would hold the alias, e.g aws-quicksight or aws-appstream whilst the real_entity_id fields would be set to 'urn:amazon:webservices'
Co-authored-by: Lyndon Garvey @lgarvey
|
@lgarvey ☝️ |
|
@xelixrob If you're happy with this, would you mind very much merging and pushing to pypi? We've been running this code from a fork of the original for a while now but it would be nice to have it merged in somewhere :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code copied from PR#124 on the original repo for this project, opened by @lgarvey on Mar 11, 2021
This is a minimal change required to provide at least the possibility of supporting multiple SP entries with the same entity id.
It's required specifically to support multiple integrations with AWS services which all use th same entity_id, but it's not possible (or logical) to create multiple ServiceProvider instances with the same entity-id. So the solution is to add an extra field in an overridden ServiceProvider instance e.g. real_entity_id which takes precedence if provided:
The entity_id field can then be used as a lookup/alias field, e.g:
/idp/sso/init?sp=aws-quicksight/idp/sso/init?sp=aws-appstreamFor each ServiceProvider instance the entity_id would hold the alias, e.g aws-quicksight or aws-appstream whilst the real_entity_id fields would be set to 'urn:amazon:webservices'