Alfredapi 520 mvc branch fix #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WimCrols
requested changes
Jun 21, 2023
apix-rest-v1/src/main/java/eu/xenit/apix/rest/v1/ApixV1Webscript.java
Outdated
Show resolved
Hide resolved
|
@WimCrols I think you might have to override the merge, since it looks like the jenkins-build requirements are still applied to this pr? |
|
Hm, this branch probably still has a Jenkinsfile. Ok, I'll see what I can do. |
|
@RVanhuysseXenit I overrode it, but none of those status checks came from Jenkins, but from GHA actually, so I don't understand why we see them twice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-520
Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
@ExceptionHandlerin the webscript classes?this.prefix avoided?See README.md for full explanation.