Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alfredapi-527: ports #186

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Alfredapi-527: ports #186

merged 3 commits into from
Dec 4, 2023

Conversation

WimCrols
Copy link
Collaborator

@WimCrols WimCrols commented Nov 30, 2023 •
edited
Loading

Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-527

  • Is CHANGELOG.md extended?
  • Does this PR avoid breaking the API?
    Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
  • Does the PR comply to REST HTTP result codes policy outlined in the user guide?
  • Is error handling done through a method annotated with @ExceptionHandler in the webscript classes?
  • Does the PR follow our coding styleguide and other active procedures?
  • Is usage of this. prefix avoided?

See README.md for full explanation.

@WimCrols WimCrols force-pushed the ALFREDAPI-527/ports branch 2 times, most recently from 8343afd to a42f9af Compare December 4, 2023 08:03
@todorinskiz
Copy link
Member

Test failed with

Could not build image: received unexpected HTTP status: 503 Service Unavailable

@WimCrols
Copy link
Collaborator Author

WimCrols commented Dec 4, 2023

Fixed

@WimCrols WimCrols changed the title Alfredapi 527/ports Alfredapi-527: ports Dec 4, 2023
Brobrechts
Brobrechts approved these changes Dec 4, 2023
View reviewed changes
Copy link

@Brobrechts Brobrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed,

The ephemeral part used to be done for Jenkins which could only spin up 1 instance (because it could only take port 8080 once)

Now with GHA this limitation does not exists anymore, and makes it easier to pin the port on 8080.

Thanks for explaining.

@WimCrols WimCrols force-pushed the ALFREDAPI-527/ports branch from 20c19c3 to 6a04bfd Compare December 4, 2023 12:45
@WimCrols WimCrols merged commit 55e1ed5 into master Dec 4, 2023
10 checks passed
@WimCrols WimCrols deleted the ALFREDAPI-527/ports branch December 4, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brobrechts Brobrechts Brobrechts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WimCrols @todorinskiz @Brobrechts