Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALFREDAPI-548-split [Add] Alfresco V23.1 & V23.2 support #221

Merged
merged 28 commits into from
Aug 12, 2024
Merged

ALFREDAPI-548-split [Add] Alfresco V23.1 & V23.2 support #221

merged 28 commits into from
Aug 12, 2024

Conversation

codingBenVdS
Copy link
Contributor

@codingBenVdS codingBenVdS commented Jun 19, 2024 •
edited
Loading

[Add] Alfresco V23.1 - V23.2 support
Breaking changes:
* JDK11 --> JDK 17
* Library changes from Javax to Jakarta
* Tomcat V10.1: this comes with a breaking change in the dispatchservlet, blocking the MultiPart handling and blocks double forward slashes
* [Fix] has to be deployed from your tomcat image! You will have to update your META-INF/context.xml in tomcat. See subproject apix-docker.
* Dropped all support for older Alfresco version prior to V23.1 just as alfresco-mvc

Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-548

  • Is CHANGELOG.md extended?
  • Does this PR avoid breaking the API?
    Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
  • Does the PR comply to REST HTTP result codes policy outlined in the user guide?
  • Is error handling done through a method annotated with @ExceptionHandler in the webscript classes?
  • Does the PR follow our coding styleguide and other active procedures?
  • Is usage of this. prefix avoided?

See README.md for full explanation.

WimCrols
WimCrols requested changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@WimCrols WimCrols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already writing down the few things we discussed as reminders.

apix-integrationtests-server/src/main/java/eu/xenit/apix/server/ApplicationContextSetter.java Outdated Show resolved Hide resolved
settings.gradle Outdated Show resolved Hide resolved
apix-integrationtests-server/build.gradle Show resolved Hide resolved
apix-integrationtests-server/src/main/java/eu/xenit/apix/server/ApplicationContextProvider.java Outdated Show resolved Hide resolved
apix-integrationtests-server/src/main/java/eu/xenit/apix/server/ApplicationContextSetter.java Show resolved Hide resolved
apix-integrationtests/alfresco/src/main/java/eu/xenit/apix/tests/BaseTest.java Outdated Show resolved Hide resolved
todorinskiz
todorinskiz reviewed Jul 15, 2024
View reviewed changes
apix-impl/build.gradle Outdated Show resolved Hide resolved
@codingBenVdS codingBenVdS force-pushed the ALFREDAPI-548-split branch from 7fbe374 to 0c64c48 Compare July 18, 2024 09:51
todorinskiz
todorinskiz reviewed Jul 22, 2024
View reviewed changes
apix-integrationtests-client/alfresco/build.gradle Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@codingBenVdS codingBenVdS force-pushed the ALFREDAPI-548-split branch from eb9975c to 97e109b Compare July 23, 2024 12:45
WimCrols
WimCrols requested changes Jul 30, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
apix-integrationtests-client/alfresco/build.gradle Show resolved Hide resolved
apix-integrationtests-client/alfresco/build.gradle Outdated Show resolved Hide resolved
apix-rest-v1/src/main/java/eu/xenit/apix/rest/CheckTomcatConfiguration.java Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
alfresco/231/overrides.gradle Show resolved Hide resolved
apix-docker/build.gradle Outdated Show resolved Hide resolved
@codingBenVdS codingBenVdS force-pushed the ALFREDAPI-548-split branch 2 times, most recently from cf13fd0 to b2fd670 Compare August 6, 2024 08:08
@WimCrols
Copy link
Collaborator

WimCrols commented Aug 8, 2024

Question @codingBenVdS : with the rename of rest-v1 to rest, did any artifact name change too? if yes, we need an update of README and installation documentation too.

WimCrols
WimCrols requested changes Aug 8, 2024
View reviewed changes
apix-docker/232/docker-compose.yml Outdated Show resolved Hide resolved
apix-impl/src/main/java/eu/xenit/apix/alfresco/CheckTomcatConfiguration.java Outdated Show resolved Hide resolved
apix-docker/231/docker-compose.yml Outdated Show resolved Hide resolved
apix-integrationtests-client/alfresco/build.gradle Show resolved Hide resolved
WimCrols
WimCrols previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@WimCrols WimCrols left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You need a rebase though.

@codingBenVdS
ALFREDAPI-548-split [Add] Alfresco V23.1 & V23.2 support
9e82f58 
  * [Delete] Alfresco V7.0 - V7.4 support
       * Too many breaking changes:
           * JDK11 => JDK17
           * javax => jakarta
codingBenVdS and others added 24 commits August 8, 2024 17:29
@codingBenVdS
ALFREDAPI-548 [Update] Fixed docker compose and being able to run int…
ff92d85 
…egration-tests without DE

  * [Broken] integration-tests are broken. The webscripts are currently not loaded in the running alfresco.
@codingBenVdS
ALFREDAPI-548-split [Update]
3755e30 
  * Only supports Alfresco V23.1.0 && V23.2.1
  * Javax => Jakarta Library
  * JDK 11 => JDK 17
  * Dynamic-Extensions (DE) support dropped. Removed any plugin with DE for Alfresco 23.1 23.2 support
  * Changed the 'eu.xenit.alfresco-remote-testrunner' to JUnit-remote testrunner using nano-http technology.
     * Added JUnit-server subproject that sets up the server + makes the application context statically available
     * Read-in the static application-context to have all Alfresco/Apix beans available for the integration-tests.
     * Set Integration-tests Helper classes into the server subproject to make them available on the runtime-classpath for integration-tests
         * Used to be done via DE-OSGI-bundle magic (Swapping application-context during runtime).

  Current situation all integration-tests should be fixed besides 7 failing tests.
  All failing due to Postmapping not working correctly. "File not received" (Tests fail in Postman aswell).
@codingBenVdS
ALFREDAPI-548-split [Update]
0a85ac0
@codingBenVdS
ALFREDAPI-548-split [Fix] Integrationtest build
3c42755 
  * Added integration-tests port 4578 to docker-build Alfresco V23.2
@codingBenVdS
ALFREDAPI-548-split [Update] Loading in beans via overving and constr…
a7c6734 
…uctors
@codingBenVdS
ALFREDAPI-548-split [Add] Tomcat context.xml file that initialises th…
29eef55 
…e dispatchServlet of Tomcat10 to allow MuliPartConfiguration and multiple forwadr slashes.

    * [REMARK] This fix will only run in the Alfred-API docker-compose. This has to be implemented on the imported projects.
    * context.xml file has to be copied to ${TOMCAT_HOME}/webapps/alfresco/META-INF/context.xml
*  [Integration-test] VersionHistoryService has a weird apix issue.
    * createVersion via the apix Implementation returns a license RO-issue. (Alfresco is not in RO-mode)
    * Solved by changing apixVersionHistory to AlfrescoVersionHistory Bean...
@codingBenVdS
ALFREDAPI-548 [CLEANUP] clean old comments and bad code.
299aec7
@codingBenVdS
ALFREDAPI-548 [Update] Remove old comments and logging.
7b9f64e 
  * Change severity of some logging.
  * Implement getBeans method in the BaseClass
  * Trying to Set Beans into the ApplicationContext will not be possible
       This is due to the setup not triggering the context initialization
       process making our own applicationContext unavailable for updates
       Meaning we cannot add beans to work with Autowire.
@codingBenVdS
ALFREDAPI-548 [Update] README & Changelog
c0b0ff8
@codingBenVdS
ALFREDAPI-548 [Fix] Bulk webscript tests
5e3e447
@codingBenVdS
ALFREDAPI-548 [Fix] CheckoutChackingTest.java
b489d68
@codingBenVdS
ALFREDAPI-548 [update] apix-impl build.gradle
e2f6d9c
@codingBenVdS
ALFREDAPI-548 [Cleanup] Version to 6.0.0
f968002
@todorinskiz @codingBenVdS
ALFREDAPI-548 Removed javax jaxb
8fef0c7
@codingBenVdS
ALFREDAPI-548 [Add] Runtime-error for Tomcat Context.xml
ec01b84 
  * Ticket: https://xenitsupport.jira.com/browse/ALFREDAPI-559
@codingBenVdS
ALFREDAPI-548 [Update] Alfresco V23.2 SOLR:2.0.8.2 to 2.0.9.1
20c2481
@codingBenVdS
ALFREDAPI-548 [Update] jaxb-api issues
a7bb68f 
  * Reverted JAcksonObjectMapper fix.
@codingBenVdS
ALFREDAPI-548 [Update] Fix CI build
98fd5bd 
  * [Cleanup] clean-up some old code + Formatting

ALFREDAPI-548 [test]

ALFREDAPI-548 [test]

ALFREDAPI-548 [Test] Move task out of all/subprojects

ALFREDAPI-548 [Test] Check docker-compose versino in ci
  * Build fails on ci but succeeds locally

ALFREDAPI-548 [Test] Setup docker-compose installation (not present in ci build)

ALFREDAPI-548 [Test] Set docker-compose into container

ALFREDAPI-548 [Test] Fix ci build
@codingBenVdS
ALFREDAPI-548 [Reformat]
b5e1f4b
@codingBenVdS
ALFREDAPI-548 [Reformat]
014b98c
@codingBenVdS
ALFREDAPI-548 [Update] Update docker-alfresco plugin
f7f385b 
  * Update docker-alfresco v5.3.1 => v5.5.0
  * fix docker-compose down issue locally
@codingBenVdS
ALFREDAPI-548 [Cleanup] gradle build
c9951fc
@codingBenVdS
ALFREDAPI-548 [Removed] tomcat context.xml check
9d1a40c
@codingBenVdS
ALFREDAPI-548 [Update] default_value to fix composeDown
9010ddb
WimCrols
WimCrols approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@WimCrols WimCrols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codingBenVdS codingBenVdS dismissed todorinskiz’s stale review August 12, 2024 06:56

PR is approved & Reviewed by Wim C. Looks like this is overruling the approval.

@codingBenVdS codingBenVdS merged commit ce330f1 into master Aug 12, 2024
5 checks passed
@codingBenVdS codingBenVdS deleted the ALFREDAPI-548-split branch August 12, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todorinskiz todorinskiz todorinskiz left review comments

@WimCrols WimCrols WimCrols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codingBenVdS @WimCrols @todorinskiz