-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indication to Admin Console if required meter-registry dependency is missing #99
Comments
Another option is to clearly reflect that it's not in the classpath and therefore won't work. |
To be clear, I don't agree with the current title:
I believe we should better reflect in the Admin Console panel that a certain implementation is not active because the required jar is not in the classpath. However disabling these by default, complicates the setup procedure IMO. Do you agree @hvancamp ? |
If we can indicate on this admin page that indeed the micrometer-registry-graphite.jar is missing from the classpath and therefore the graphite registry won't work then there is indeed no need to disable it by default. |
I have some work-in-progress code laying around that did just that. I'll
block some time Friday to see if it is salvageable.
…On Tue, 18 May 2021 at 09:29, Hannes Van Camp ***@***.***> wrote:
If we can indicate on this admin page that indeed the
micrometer-registry-graphite.jar is missing from the classpath and
therefore the graphite registry won't work then there is indeed no need to
disable it by default.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIMEW6K3ATEDDE37PF5PCTTOIJMTANCNFSM44JMPTOQ>
.
|
Ping @tgeens |
1 similar comment
Ping @tgeens |
By default Alfred Telemetry is configured to use the graphite registry but it won't work OOTB unless the micrometer-registry-graphite jar is also installed which is not the case. Therefore it would be better to disable the graphite registry by default.
The text was updated successfully, but these errors were encountered: