Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indication to Admin Console if required meter-registry dependency is missing #99

Open
hvancamp opened this issue May 7, 2021 · 6 comments

Comments

@hvancamp
Copy link

hvancamp commented May 7, 2021

By default Alfred Telemetry is configured to use the graphite registry but it won't work OOTB unless the micrometer-registry-graphite jar is also installed which is not the case. Therefore it would be better to disable the graphite registry by default.

alfred-telemetry-graphite-registry

@kerkhofsd
Copy link
Contributor

Another option is to clearly reflect that it's not in the classpath and therefore won't work.

@kerkhofsd
Copy link
Contributor

kerkhofsd commented May 12, 2021

To be clear, I don't agree with the current title:

Graphite integration should be disabled by default

I believe we should better reflect in the Admin Console panel that a certain implementation is not active because the required jar is not in the classpath. However disabling these by default, complicates the setup procedure IMO.

Do you agree @hvancamp ?

@hvancamp
Copy link
Author

If we can indicate on this admin page that indeed the micrometer-registry-graphite.jar is missing from the classpath and therefore the graphite registry won't work then there is indeed no need to disable it by default.

@tgeens
Copy link
Contributor

tgeens commented May 19, 2021 via email

@kerkhofsd
Copy link
Contributor

Ping @tgeens

1 similar comment
@kerkhofsd
Copy link
Contributor

Ping @tgeens

@kerkhofsd kerkhofsd changed the title Graphite integration should be disabled by default Add indication to Admin Console if required meter-registry dependency is missing Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants