Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproduction for overwriting files in a war with an AMP #238

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

vierbergenlars
Copy link
Member

Overwriting files in an alfresco WAR with an AMP should work, also when using the alfrescoWar task.
It appears that this issue was already fixed as a side-effect of #220, where duplicates strategy was
changed from EXCLUDE to INCLUDE.

Fixes #229

@vierbergenlars vierbergenlars added the bug Something isn't working label Oct 22, 2021
@vierbergenlars vierbergenlars added this to the 5.3.1 milestone Oct 22, 2021
@vierbergenlars vierbergenlars changed the title Add reproduction for #229 Add reproduction for overwriting files in a war with an AMP. Oct 22, 2021
@vierbergenlars vierbergenlars changed the title Add reproduction for overwriting files in a war with an AMP. Add reproduction for overwriting files in a war with an AMP Oct 22, 2021
@vierbergenlars vierbergenlars force-pushed the issue-229 branch 2 times, most recently from b989aec to 93edab7 Compare October 25, 2021 09:50
Overwriting files in an alfresco WAR with an AMP should work, also when
using the `alfrescoWar` task.
It appears that this issue was already fixed as a side-effect of
f493862 (PR #220), where duplicates strategy was
changed from EXCLUDE to INCLUDE.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thijslemmens thijslemmens merged commit 240ced9 into master Nov 22, 2021
@thijslemmens thijslemmens deleted the issue-229 branch November 22, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overwriting files in WAR with AMP broken since v5.3.0 - required for e.g. applying hotfixes
2 participants