Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example sharded setup. #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Example sharded setup. #5

wants to merge 1 commit into from

Conversation

anghelutar
Copy link
Contributor

No description provided.

thijslemmens
thijslemmens previously approved these changes Jun 3, 2021
View reviewed changes
@thijslemmens thijslemmens dismissed their stale review June 3, 2021 11:40

I'm thinking it's getting too complicated. Maybe good to keep on a branch?

@thijslemmens
Copy link
Contributor

@anghelutar Can we keep it on a branch? I'm afraid it will confuse people checking out the master branch.

@anghelutar
Copy link
Contributor Author

Sharding is complicated, telemetry in a sharded setup is not complicated (imo).
For me is important to spread the knowledge, if it needs to be in a branch - so be it, is a detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijslemmens thijslemmens thijslemmens left review comments

@kerkhofsd kerkhofsd Awaiting requested review from kerkhofsd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anghelutar @thijslemmens