Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade OpenJDK from 11.0.9.1 to 11.0.9 for compat with alfresco-search-services 2.0 #22

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Downgrade OpenJDK from 11.0.9.1 to 11.0.9 for compat with alfresco-search-services 2.0 #22

merged 2 commits into from
Dec 15, 2020

Conversation

anghelutar
Copy link
Contributor

@anghelutar anghelutar mentioned this pull request Dec 14, 2020
Merged
@anghelutar anghelutar marked this pull request as draft December 15, 2020 08:12
@anghelutar anghelutar marked this pull request as ready for review December 15, 2020 10:54
@vierbergenlars
Copy link
Member

So, this broke because a certain jetty version was parsing java version numbers?

And from the issue you linked, it does not look like Alfresco are planning to fix it for ASS?

@tgeens tgeens changed the title Java version 11.0.9 does not work with ASS 2.0.x: Java version 11.0.9.1 does not work with ASS 2.0.x: Dec 15, 2020
@tgeens
Copy link
Contributor

tgeens commented Dec 15, 2020 •
edited
Loading

Summary

  • alfresco-search-services 2.0.x uses solr-6 and Jetty 9.3
  • Jetty 9.3 parses java version numbers - and expects 3-parts in the version number
  • Jetty 9.3 is the last supported version for solr 6 - Alfresco not planning to upgrade
  • Jetty 9.4 has a bugfix for arbitrary-length version numbers (JEP223)
  • OpenJDK released a patch 10.0.9 -> 10.0.9.1 backporting a bug fix

💥

So we'll go back to 10.0.9 for now and hope that the OpenJDK bug does not come back to bite us in the behind 😬

Tuesday, January 19 2021 GA; OpenJDK 11.0.10 release

11.0.10 is scheduled in one month from now, so this is a temp solution (until another 4-part OpenJDK patch is released)

@tgeens tgeens changed the title Java version 11.0.9.1 does not work with ASS 2.0.x: Downgrade OpenJDK from 11.0.9.1 to 11.0.9 because Alfresco-search-services does not work with 4-part java-version-numbers Dec 15, 2020
@tgeens tgeens changed the title Downgrade OpenJDK from 11.0.9.1 to 11.0.9 because Alfresco-search-services does not work with 4-part java-version-numbers Downgrade OpenJDK from 11.0.9.1 to 11.0.9 for compat with alfresco-search-services 2.0 Dec 15, 2020
@anghelutar anghelutar merged commit 55b50b2 into master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgeens tgeens tgeens approved these changes

@vierbergenlars vierbergenlars Awaiting requested review from vierbergenlars

@koenvangeerteruy koenvangeerteruy Awaiting requested review from koenvangeerteruy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anghelutar @vierbergenlars @tgeens