Skip to content

Commit

Permalink
Merge pull request #152 from xenit-eu/OUPSLA-53
Browse files Browse the repository at this point in the history
[OUPSLA-53] add defaultBackend mapToRootOnly
  • Loading branch information
gert-glassee authored May 21, 2024
2 parents fe4d0fe + 6a8a655 commit ca2ef76
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/integration-testing.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: 'Integration testing'
on:
push:
workflow_dispatch:

jobs:
integration-testing:
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
chronology things are added/fixed/changed and - where possible - links to the PRs involved.

### Changes
[v0.6.8]
* Add `ingress.defaultBackend.mapToRootOnly` to make defaultBackend creation optional.
* Add /ngnxhealth to nginx-default

[XENOPS-1166]
* add init containers to acs deployment
* fix alfresco additionalClaims split chart
Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,14 @@ For more information take a look at
* Default: 30000
* Description: the default service port that ingress will point to

#### `ingress.defaultBackend.mapToRootOnly`
* Required: false
* Default: true
* Description: This setting (active by default) will disable the defaultBackend from the actual ingress rules and ONLY use the
above defaultBackend settings to be mapped to the root `/` ingress rule.
Setting this value to `false` will activate defaultBackend ingress setting. This will create a default, hostname independent, catch-all rule.
This might be required if, for example on AWS, when an Internal loadbalancer is used that does not adhere to the hostname specific rules.

#### `ingress.blockAcsSolrApi.enabled`

* Required: false
Expand Down
7 changes: 7 additions & 0 deletions xenit-alfresco/templates/ingress/alfresco-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ spec:
# Provide a unique secret to store the SSL credentials
secretName: tls-alfresco-{{ .Release.Name }}-secret
{{- end }}
{{- if not .Values.ingress.defaultBackend.mapToRootOnly }}
defaultBackend:
service:
name: {{ .Values.ingress.defaultBackend.service }}
port:
number: {{ .Values.ingress.defaultBackend.port }}
{{- end }}
rules:
- host: {{ required "A host where your alfresco services can be reached on must be specified in values.ingress.host" .Values.ingress.host }}
http:
Expand Down
5 changes: 5 additions & 0 deletions xenit-alfresco/templates/ingress/nginx-default-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ data:
server {
listen 80;
server_name _;
location /ngnxhealth {
add_header 'Content-Type' 'application/json';
access_log off;
return 200 '{"status":"UP"}';
}
{{- if .Values.ingress.blockAcsSolrApi.enabled -}}
{{- range $.Values.ingress.blockAcsSolrApi.paths }}
location {{ . }} {
Expand Down
2 changes: 2 additions & 0 deletions xenit-alfresco/templates/ingress/nginx-default-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ apiVersion: v1
kind: Service
metadata:
name: nginx-default-service
annotations:
alb.ingress.kubernetes.io/healthcheck-path: /ngnxhealth
namespace: {{ .Release.Namespace | quote }}
spec:
{{- if .Values.general.serviceType }}
Expand Down
1 change: 1 addition & 0 deletions xenit-alfresco/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ ingress:
kubernetes.io/ingress.class: "nginx"
cert-manager.io/cluster-issuer: "letsencrypt-production"
defaultBackend:
mapToRootOnly: true
service: nginx-default-service
port: 30403
blockAcsSolrApi:
Expand Down

0 comments on commit ca2ef76

Please sign in to comment.