Reserve the first slot to redirect L2 flows to queue 0

xenogenics · Nov 28, 2023 · f1852a4 · f1852a4
1 parent 709a56b
commit f1852a4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/transport/ena/Port.cpp b/src/transport/ena/Port.cpp
@@ -384,7 +384,14 @@ Port::setupReceiveSideScaling(struct rte_eth_dev_info const& dev_info,
      */
     hlen = ENA_LEGACY_HASH_KEY_LEN;
     hkey = new uint8_t[hlen];
-    memcpy(hkey, ENA_LEGACY_HASH_KEY, hlen);
+    /*
+     * Copy the legacy key by flipping it:
+     *
+     * https://github.com/amzn/amzn-drivers/issues/267#issuecomment-1566119986
+     */
+    for (size_t i = 0; i < ENA_LEGACY_HASH_KEY_LEN; i += 1) {
+      hkey[i] = ENA_LEGACY_HASH_KEY[ENA_LEGACY_HASH_KEY_LEN - i];
+    }
   }
   /*
    * Allocate the redirection table.

diff --git a/src/transport/ena/RawProcessor.cpp b/src/transport/ena/RawProcessor.cpp
@@ -1,6 +1,7 @@
 #include <tulips/stack/Ethernet.h>
 #include <tulips/system/SpinLock.h>
 #include <tulips/transport/ena/RawProcessor.h>
+#include <iostream>
 #include <mutex>
 #include <netinet/in.h>
 

diff --git a/src/transport/ena/RedirectionTable.cpp b/src/transport/ena/RedirectionTable.cpp
@@ -25,9 +25,6 @@ RedirectionTable::RedirectionTable(const uint16_t portid, const size_t nqus,
   }
   /*
    * Partition the RETA.
-   *
-   * NOTE(xrg): we don't allocate any slot for queue 0 as its sole purpose it to
-   * handle L2 messages.
    */
   for (size_t i = 0; i < nqus - 1; i += 1) {
     for (size_t j = 0; j < partlen; j += 1) {
@@ -45,6 +42,10 @@ RedirectionTable::RedirectionTable(const uint16_t portid, const size_t nqus,
     auto eidx = i & 0x3F;
     m_table[slot].reta[eidx] = nqus - 1;
   }
+  /*
+   * Reserve the first slot to redirect L2 flows to queue 0.
+   */
+  m_table[0].reta[0] = 0;
   /*
    * Update the RETA.
    */