Test and fix usb reset mount #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a rootless container (like unshare --map-root-user --mount) to test the correct calling convention for mount()/umount(). Use a context manager test fixture to temporarily mock module imports: This allows to mock global modules only temporary for importing the testee without affecting other tests. - Add a sufficient testcase to test usb_reset.py: mount() and umount() without mocking the system or library calls in any way. - Use python3/tests a Python tests package to allow for non-deprecated relative imports: Absolute imports within a module are deprecated. Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
…et-mount Signed-off-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
bernhardkaindl
merged commit 50e7168
into
xenserver-next:test-and-fix-usb_reset-mount
6 of 7 checks passed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't push directly to the branch, so I'm opening this PR because I think this two commits should replace the current contents of the PR: xapi-project#5565