Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: be explicit about what bool values are accepted #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ydirson
Copy link
Contributor

@ydirson ydirson commented Jul 30, 2024

No description provided.

Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
@freddy77
Copy link
Collaborator

Maybe would be worth stating the comparison is done case-insensitive.

Not a regression, I found a small exception due to code:

    def parseUIConfirmationPrompt(self):
        results = {}
        nodes = getElementsByTagName(self.top_node, ['ui-confirmation-prompt'])
        if len(nodes) > 0:
            results['ui-confirmation-prompt'] = bool(getText(nodes[0]))
        return results

The bool conversion will return true for any not empty string, even "false" or "0".

@GeraldEV
Copy link
Collaborator

It would be good to address the issue @freddy77 raised to ensure that the docs are correct when this PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants