Upgrade: forbid upgrading with a key XAPI will reject #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbrett
reviewed
Sep 16, 2024
upgrade.py
Outdated
| primary_fs.unmount() | ||
|
|
||
| def testUpgradeForbidden(self, tool): | ||
| if tool.partTableType == constants.PARTITION_DOS: | ||
| raise RuntimeError("Upgrade from a DOS partition type is not supported.") | ||
| if self.key_size < 2048: | ||
| raise RuntimeError("Server certificate is too small, must regenerate on 8.2.1 before upgrade.") |
There was a problem hiding this comment.
I'm nervous about stating a specific version number, perhaps better to have this as e.g. "Current server certificate is too small (%d bits), please regenerate with at least 2048 bits" % (self.key_size,)?
(It may also be a good idea to encode the 2048 as a MIN_KEY_SIZE constant in case this needs to change in the future)
There was a problem hiding this comment.
adjusted in last push
ydirson
force-pushed
the
for-xs/certificate-keysize-protection
branch
2 times, most recently
from
f330c6a
to
1871e0a
Compare
XAPI now rejects the default keysize of 7.x era, which must be regenerated before upgrading to 8.3. Let the installer refuse to initiate a situation where a Rolling Pool Upgrade would be unable to proceed, with not-yet-updated slaves holding the running VMs getting refused connection to the updated part of the pool. Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
ydirson
force-pushed
the
for-xs/certificate-keysize-protection
branch
from
1871e0a
to
8ab5b8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XAPI now rejects the default keysize of 7.x era, which must be regenerated before upgrading to 8.3. Let the installer refuse to initiate a situation where a Rolling Pool Upgrade would be unable to proceed, with not-yet-updated slaves holding the running VMs getting refused connection to the updated part of the pool.
This now stops the upgrade with the following screen, but after letting the user give consent for launching the upgrade: