Skip to content

Commit

Permalink
tox.ini and CI: Move pytype to Py3.8 and remove 3.7 and 3.9 builds
Browse files Browse the repository at this point in the history
- pytype has several problems to import libraries when used on
  Python 3.10, therefore move it Python 3.8.
- tox.ini, GitHub CI: Remove builds for 3.7 and 3.9 builds
  because they showed intermittent pytest failures and
  we shoud not used them as new Python versions anyways.

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
  • Loading branch information
bernhardkaindl committed Jun 13, 2023
1 parent bae9996 commit 2f6fdd8
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 22 deletions.
4 changes: 0 additions & 4 deletions .github/act-serial.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ jobs:
os: ubuntu-20.04
- python-version: '3.10'
os: ubuntu-latest
- python-version: '3.9'
os: ubuntu-latest
- python-version: '3.7'
os: ubuntu-latest
- python-version: '3.6'
os: ubuntu-20.04
runs-on: ${{ matrix.os }}
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ jobs:
os: ubuntu-20.04
- python-version: '3.10'
os: ubuntu-latest
- python-version: '3.9'
os: ubuntu-latest
- python-version: '3.7'
os: ubuntu-latest
- python-version: '3.6'
os: ubuntu-20.04
runs-on: ${{ matrix.os }}
Expand Down
26 changes: 12 additions & 14 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# Later in the order:
# 3. pyre and mypy
# 4. pytype
envlist = py36-lint, py311-pyre, py39-check, py310-pytype, py37-mdreport, py38-covcombine
envlist = py36-lint, py311-pyre, py310-check, py38-pytype, py38-covcombine
isolated_build = true
skip_missing_interpreters = true
requires =
Expand Down Expand Up @@ -48,6 +48,7 @@ description = Run in a {basepython} virtualenv:
pytype: Run pytype for static analyis, intro: https://youtu.be/abvW0mOrDiY
# checkers(mypy) need the pytest dependices as well:
extras =
{check,pytype}: {[check]extras}
{cov,covcp,covcombine,fox,check,lint,test,pytype,pyre,mdreport}: {[test]extras}
{cov,covcp,covcombine,fox}: {[cov]extras}
deps =
Expand All @@ -57,10 +58,9 @@ deps =
{cov,covcp,covcombine,fox}: coverage[toml]
{cov,covcp,covcombine,fox}: diff-cover
{lint,fox}: {[lint]deps}
check: {[check]deps}
pyre: pyre-check
pyre: pyre-extensions
pytype: {[check]deps}
pyre: pyright
pytype: {[pytype]deps}
allowlist_externals =
{cov,covcp,covcombine,fox,check,lint,test,pytype,pyre,mdreport}: echo
Expand Down Expand Up @@ -188,17 +188,14 @@ python =
3.11: py311

[check]
deps =
lxml
mypy
mypy-extensions
typing_extensions
types-mock
types-simplejson
types-six
extras = mypy
commands =
mypy --txt-report .
cat index.txt
mypy --txt-report {envlogdir}
cat {envlogdir}/index.txt

[pycodestyle]
ignore = W191,W293,W504,E101,E126,E127,E201,E202,E203,E221,E222,E226,E227,E241,E251,E261,E262,E265,E301,E302,E303,E305,E722,W391,E401,E402,E741
max-line-length = 129

[pyre]
commands =
Expand All @@ -210,5 +207,6 @@ commands =
deps = pytype
pandas
commands =
python3.10 --version -V # Needs py310, does not support with py311 yet:
python3.8 -V # Needs python <= 3.10; but 3.10 has an issue with newer xml.dom.minidom
pytype --version
python ./run-pytype.py

0 comments on commit 2f6fdd8

Please sign in to comment.