xcp/cpiofile.py: Fix warning: Reimport 'bz2' (imported line 48) #58
+0
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 70.90% 70.97% +0.06%
==========================================
Files 21 21
Lines 3471 3462 -9
==========================================
- Hits 2461 2457 -4
+ Misses 1010 1005 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
psafont
reviewed
May 31, 2023
Two weeks ago when adding cast()s to bz2 types, I merged a toplevel `import bz2` because in currently used Python builds bz2 is built-in. It's time to remove the non-toplevel `import bz2` lines which now trigger several warnings: "Reimport 'bz2' (imported line 48)" Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
cpiofile-fix-reimport-bz2
branch
from
ef591eb to
f2c6ebc
Compare
rosslagerwall
approved these changes
May 31, 2023
bernhardkaindl
commented
May 31, 2023
There was a problem hiding this comment.
@psafont Pushed a backout of the change to the file mode and the shebang line.
Currently, 19 of the 46 *.py files have the shebang and it's not a problem to have it,
it should just be superflous, I believe, but that's not for now.
psafont
approved these changes
Jun 1, 2023
bernhardkaindl
added a commit
to xenserver-next/python-libs
that referenced
this pull request
Jun 14, 2023
As discussed in xenserver#58: Only files which will be execute by invoking them directly require the shebang. If a library module would be used as a script as well, the file could have to contain a __name__ guard to prevent it to be executed on importing it: if __name__ == "__main__": main() None of the files in xcp/* have such __name__ guard, hence we can safely cleanup the excess shebangs in xcp. Even the copyright headers in the otherwise empty __init__.py files have the shebangs, so it looks like the shebangs were just added as part of the copyright header. It could have been used as a marker for editors to switch to Python mode, about stackoverflow agrees that that's not needed. Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
added a commit
to xenserver-next/python-libs
that referenced
this pull request
Jun 15, 2023
As discussed in xenserver#58: Only files which will be execute by invoking them directly require the shebang. If a library module would be used as a script as well, the file could have to contain a __name__ guard to prevent it to be executed on importing it: if __name__ == "__main__": main() None of the files in xcp/* have such __name__ guard, hence we can safely cleanup the excess shebangs in xcp. Even the copyright headers in the otherwise empty __init__.py files have the shebangs, so it looks like the shebangs were just added as part of the copyright header. It could have been used as a marker for editors to switch to Python mode, about stackoverflow agrees that that's not needed. Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two weeks ago when adding cast()s to bz2 types,
I merged a toplevel
import bz2because in currently used Python builds bz2 is built-in.It's time to remove the non-toplevel
import bz2lines which now trigger several warnings:"Reimport 'bz2' (imported line 48)"`