Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use ThisBuild version for sonatypeBundleDirectory #199

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Always use ThisBuild version for sonatypeBundleDirectory #199

merged 1 commit into from
Nov 2, 2020

Conversation

hugo-vrijswijk
Copy link
Contributor

@hugo-vrijswijk hugo-vrijswijk commented Nov 2, 2020

Fixes #197

Changes sonatypeBundleDirectory to always use the version directory of the root project.

Before:

sbt:root> version
[info] module-a / version
[info]  1.4.1
[info] module-b / version
[info]  1.4.0
[info] version
[info]  1.4.0
sbt:root> sonatypeBundleDirectory
[info] module-a / sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.1
[info] module-b / sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0
[info] sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0

After:

sbt:root> version
[info] module-a / version
[info]  1.4.1
[info] module-b / version
[info]  1.4.0
[info] version
[info]  1.4.0
sbt:root> sonatypeBundleDirectory
[info] module-a / sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0
[info] module-b / sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0
[info] sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0

Changes `sonatypeBundleDirectory` to always use the version directory of the root project.

Before:

```
sbt:mutation-testing-metrics-scala> version
[info] module-a / version
[info]  1.4.1
[info] module-b / version
[info]  1.4.0
[info] version
[info]  1.4.0
sbt:mutation-testing-metrics-scala> sonatypeBundleDirectory
[info] module-a / sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.1
[info] module-b / sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0
[info] sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0
```

After:

```
sbt:root> version
[info] module-a / version
[info]  1.4.1
[info] module-b / version
[info]  1.4.0
[info] version
[info]  1.4.0
sbt:root> sonatypeBundleDirectory
[info] module-a / sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0
[info] module-b / sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0
[info] sonatypeBundleDirectory
[info]  /root/target/sonatype-staging/1.4.0
```
@hugo-vrijswijk
Copy link
Contributor Author

Formatting is failing but it seems unrelated to this change. I can run formatting but that would pollute this PR a little

@xerial xerial merged commit 827163f into xerial:master Nov 2, 2020
@xerial
Copy link
Owner

xerial commented Nov 2, 2020

Thanks for the PR! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOException with different versions on subprojects
2 participants