Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computation of sonatypeDefaultResolver for Sonatype Central #501

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Jul 26, 2024

Without the main change, the test fails:

[info] [error] (checkSonatypeDefaultResolver) java.lang.IllegalArgumentException: requirement failed: expected URLRepository(https://SettingKey(This / This / This / sonatypeCredentialHost), Patterns(ivyPatterns=Vector(), artifactPatterns=Vector(), isMavenCompatible=false, descriptorOptional=false, skipConsistencyCheck=false), false) to be URLRepository(https://central.sonatype.com, Patterns(ivyPatterns=Vector(), artifactPatterns=Vector(), isMavenCompatible=false, descriptorOptional=false, skipConsistencyCheck=false), false)

Notably:

https://SettingKey(This / This / This / sonatypeCredentialHost)
vs
https://central.sonatype.com

@kubukoz
Copy link
Contributor Author

kubukoz commented Jul 26, 2024

Note that I haven't confirmed that this fully unblocks publishing, but it does resolve a problem from sbt-typelevel.

@kubukoz kubukoz marked this pull request as ready for review July 26, 2024 16:09
@kubukoz
Copy link
Contributor Author

kubukoz commented Jul 26, 2024

hey @xerial, mind taking a look?

also, this repository seems to be quite commonly relied on in the Scala ecosystem, and it looks like there's only one maintainer - have you considered moving this project to the sbt organization?

@xerial
Copy link
Owner

xerial commented Jul 26, 2024

@kubukoz Thanks. I'll release a new version soon.

have you considered moving this project to the sbt organization?
It sounds like a good idea, as Sonatype has added new types of APIs and different kinds of accounts (s01, etc.), so testing and maintaining sbt-sonatype only by myself has reached its limit. I just opened a discussion thread: #502. Let's discuss potential directions there.

@xerial xerial merged commit 8f8b370 into xerial:master Jul 26, 2024
5 checks passed
@xerial
Copy link
Owner

xerial commented Jul 26, 2024

Just released https://github.com/xerial/sbt-sonatype/releases/tag/v3.11.1

@kubukoz kubukoz deleted the fix-sonatypeDefaultResolver branch July 27, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants