Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#302 Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) #303

Merged
merged 1 commit into from
May 18, 2022
Merged

#302 Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) #303

merged 1 commit into from
May 18, 2022

Conversation

zh-muxa
Copy link
Contributor

@zh-muxa zh-muxa commented Jan 19, 2022 •
edited
Loading

Fixing issue #302

@chrisrueger
Copy link

chrisrueger commented Mar 7, 2022 •
edited
Loading

We have this issue too with bndtools 6.2.0 and the fix for #302 seems to address this.
Our error with 1.1.8.4 is:

Unresolved requirement: Require-Capability: osgi.native; native.paths.8:List<String>="org/xerial/snappy/native/Linux/x86_64/libsnappyjava.so"; native.paths.17:List<String>="org/xerial/snappy/native/SunOS/x86/libsnappyjava.so"; native.paths.7:List<String>="org/xerial/snappy/native/Linux/x86_64/libsnappyjava.so"; native.paths.16:List<String>="org/xerial/snappy/native/AIX/ppc64/libsnappyjava.a"; native.paths.19:List<String>="org/xerial/snappy/native/SunOS/sparc/libsnappyjava.so"; native.paths.9:List<String>="org/xerial/snappy/native/Linux/x86/libsnappyjava.so"; native.paths.18:List<String>="org/xerial/snappy/native/SunOS/x86_64/libsnappyjava.so"; native.paths.13:List<String>="org/xerial/snappy/native/Linux/ppc64/libsnappyjava.so"; native.paths.12:List<String>="org/xerial/snappy/native/Linux/armv7/libsnappyjava.so"; native.paths.15:List<String>="org/xerial/snappy/native/AIX/ppc/libsnappyjava.a"; native.paths.14:List<String>="org/xerial/snappy/native/Linux/s390x/libsnappyjava.so"; native.paths.11:List<String>="org/xerial/snappy/native/Linux/arm/libsnappyjava.so"; native.paths.10:List<String>="org/xerial/snappy/native/Linux/aarch64/libsnappyjava.so"; native.paths.0:List<String>="org/xerial/snappy/native/Windows/x86_64/snappyjava.dll"; native.paths.2:List<String>="org/xerial/snappy/native/Windows/x86_64/snappyjava.dll"; native.paths.1:List<String>="org/xerial/snappy/native/Windows/x86_64/snappyjava.dll"; native.paths.4:List<String>="org/xerial/snappy/native/Mac/x86/libsnappyjava.dylib"; native.paths.3:List<String>="org/xerial/snappy/native/Windows/x86/snappyjava.dll"; native.paths.6:List<String>="org/xerial/snappy/native/Linux/x86_64/libsnappyjava.so"; native.paths.5:List<String>="org/xerial/snappy/native/Mac/x86_64/libsnappyjava.dylib"; filter:="(|(&(osgi.native.osname~=win32)(osgi.native.processor~=x86-64))(&(osgi.native.osname~=win32)(osgi.native.processor~=x64))(&(osgi.native.osname~=win32)(osgi.native.processor~=amd64))(&(osgi.native.osname~=win32)(osgi.native.processor~=x86))(&(osgi.native.osname~=macosx)(osgi.native.processor~=x86))(&(osgi.native.osname~=macosx)(osgi.native.processor~=x86-64))(&(osgi.native.osname~=linux)(osgi.native.processor~=x86-64))(&(osgi.native.osname~=linux)(osgi.native.processor~=x64))(&(osgi.native.osname~=linux)(osgi.native.processor~=amd64))(&(osgi.native.osname~=linux)(osgi.native.processor~=x86))(&(osgi.native.osname~=linux)(osgi.native.processor~=aarch64))(&(osgi.native.osname~=linux)(osgi.native.processor~=arm))(&(osgi.native.osname~=linux)(osgi.native.processor~=arm_le))(&(osgi.native.osname~=linux)(osgi.native.processor~=ppc64le))(&(osgi.native.osname~=linux)(osgi.native.processor~=s390x))(&(osgi.native.osname~=aix)(osgi.native.processor~=ppc))(&(osgi.native.osname~=aix)(osgi.native.processor~=ppc64))(&(osgi.native.osname~=sunos)(osgi.native.processor~=x86))(&(osgi.native.osname~=sunos)(osgi.native.processor~=x86-64))(&(osgi.native.osname~=sunos)(osgi.native.processor~=sparc)))"

A merge would be appreciated.

@xerial xerial merged commit 78354b6 into xerial:master May 18, 2022
@xerial
Copy link
Owner

xerial commented May 18, 2022

Merged. Thanks!

@chrisrueger
Copy link

@xerial Thanks. Is there any estimate for a new release including this fix? Currently on maven central 1.1.8.4 is the most recent from Jan 2021

@refset refset mentioned this pull request Aug 26, 2022
Closed
@giftkugel
Copy link

@xerial Thanks. Is there any estimate for a new release including this fix? Currently on maven central 1.1.8.4 is the most recent from Jan 2021

Would also like to know when to expect this fix as part of a release.

@dongjoon-hyun dongjoon-hyun mentioned this pull request Jan 30, 2023
Closed
dongjoon-hyun added a commit to apache/spark that referenced this pull request Feb 1, 2023
@dongjoon-hyun
[SPARK-42242][BUILD] Upgrade snappy-java to 1.1.9.1
65a1c16 
### What changes were proposed in this pull request?

This PR aims to upgrade `snappy-java` to 1.1.9.1.

### Why are the changes needed?

This version has the following bug fixes.

- Use original compressed and uncompressed buffer's position (xerial/snappy-java#293)
- Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303)
- Avoid explicit class name in throw_exception (xerial/snappy-java#291)

Here is the full release note.
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes #39811 from dongjoon-hyun/SPARK-42242.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit to apache/spark that referenced this pull request Feb 1, 2023
@dongjoon-hyun
[SPARK-42242][BUILD] Upgrade snappy-java to 1.1.9.1
9f7c926 
### What changes were proposed in this pull request?

This PR aims to upgrade `snappy-java` to 1.1.9.1.

### Why are the changes needed?

This version has the following bug fixes.

- Use original compressed and uncompressed buffer's position (xerial/snappy-java#293)
- Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303)
- Avoid explicit class name in throw_exception (xerial/snappy-java#291)

Here is the full release note.
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes #39811 from dongjoon-hyun/SPARK-42242.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 65a1c16)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
@dongjoon-hyun
[SPARK-42242][BUILD] Upgrade snappy-java to 1.1.9.1
d0af86f 
### What changes were proposed in this pull request?

This PR aims to upgrade `snappy-java` to 1.1.9.1.

### Why are the changes needed?

This version has the following bug fixes.

- Use original compressed and uncompressed buffer's position (xerial/snappy-java#293)
- Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303)
- Avoid explicit class name in throw_exception (xerial/snappy-java#291)

Here is the full release note.
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#39811 from dongjoon-hyun/SPARK-42242.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 65a1c16)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
senthh pushed a commit to acceldata-io/spark3 that referenced this pull request Aug 30, 2024
@dongjoon-hyun @senthh
[SPARK-42242][BUILD] Upgrade snappy-java to 1.1.9.1
07bb81a 
### What changes were proposed in this pull request?

This PR aims to upgrade `snappy-java` to 1.1.9.1.

### Why are the changes needed?

This version has the following bug fixes.

- Use original compressed and uncompressed buffer's position (xerial/snappy-java#293)
- Fixed running snappy-java as OSGi bundle on Apple Silicon (M1 Pro) (xerial/snappy-java#303)
- Avoid explicit class name in throw_exception (xerial/snappy-java#291)

Here is the full release note.
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#39811 from dongjoon-hyun/SPARK-42242.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 65a1c16)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zh-muxa @chrisrueger @xerial @giftkugel