Update NOTICE #492
Merged
Update NOTICE #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Notice
xerial
reviewed
Sep 5, 2023
NOTICE
Outdated
Comment on lines
19
to
44
| == Export Control Notice == | ||
| This distribution includes cryptographic software. The country in | ||
| which you currently reside may have restrictions on the import, | ||
| possession, use, and/or re-export to another country, of | ||
| encryption software. BEFORE using any encryption software, please | ||
| check your country's laws, regulations and policies concerning the | ||
| import, possession, or use, and re-export of encryption software, to | ||
| see if this is permitted. See <http://www.wassenaar.org/> for more | ||
| information. | ||
|
|
||
| The U.S. Government Department of Commerce, Bureau of Industry and | ||
| Security (BIS), has classified this software as Export Commodity | ||
| Control Number (ECCN) 5D002.C.1, which includes information security | ||
| software using or performing cryptographic functions with asymmetric | ||
| algorithms. The form and manner of this Apache Software Foundation | ||
| distribution makes it eligible for export under the License Exception | ||
| ENC Technology Software Unrestricted (TSU) exception (see the BIS | ||
| Export Administration Regulations, Section 740.13) for both object | ||
| code and source code. | ||
|
|
||
| The following provides more details on the included cryptographic software: | ||
|
|
||
| This software uses the SSL libraries from the Jetty project written | ||
| by mortbay.org. | ||
| Hadoop Yarn Server Web Proxy uses the BouncyCastle Java | ||
| cryptography APIs written by the Legion of the Bouncy Castle Inc. |
There was a problem hiding this comment.
I think this is a copy from Hadoop's notice file, but snappy-java's jar itself doesn't contain any of Hadoop products as a dependency, so this statement unnecessarily scares jar-only users of snappy-java.
This notice applied only to the source/test code, not to the published jar files. I think adding a pointer to the Hadoop's NOTICE file is more appropriate here than copying everyt sentence.
|
@imsudiproy Thanks for the fix. Merged |
|
@xerial you're welcome. Sorry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#308