Make ConnectionConfig#autoCommit configurable via fake pragma #1027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I am using Kotlin's SQL Framework https://github.com/JetBrains/Exposed with sqlite-jdbc.
I want to disable auto-commit for better performance, but it appears that it is not configurable via SQLiteConfig nor SQLiteDataSource.
SQLiteConnectionConfig offers
setAutoCommit
, butSQLiteConfig#defaultConnectionConfig
always useautoCommit = true
.sqlite-jdbc/src/main/java/org/sqlite/SQLiteConnectionConfig.java
Line 21 in 263c296
One can specify
connection.autoCommit = false
intransaction { ... }
DSL, but it is error-prone because one might forget.Proposal
This PR adds "fake" pragma
jdbc.auto_commit
, so auto-commit can be configurable via SQLiteConfig.