-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date, Time, Timestamp Distinguishing String Formats. #33
base: master
Are you sure you want to change the base?
Conversation
It looks like this change breaks existing method's behaviour: Please check the test failure: https://travis-ci.org/xerial/sqlite-jdbc/jobs/61998296 |
On Sun, May 10, 2015 11:30 pm, Taro L. Saito wrote:
Hello Taro, I have reviewed the test failure and believe it may be corrected. Before I proceed in that vein, wasting time, is it agreed that the As I indicated the SQL standard defines a Date as (yyyy-MM-dd) with Java API reference: public class java.sql.Date A thin wrapper around a millisecond value that allows JDBC To conform with the definition of SQL DATE, the millisecond |
public final static String DEFAULT_DATE_STRING_FORMAT = "yyyy-MM-dd HH:mm:ss.SSS"; | ||
public final static String DEFAULT_DATE_STRING_FORMAT = "yyyy-MM-dd"; | ||
public final static String DEFAULT_TIME_STRING_FORMAT = "HH:mm:ss"; | ||
public final static String DEFAULT_TIMESTAMP_STRING_FORMAT = "yyyy-MM-dd HH:mm:ss.SSS"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not concat?
DATE_STRING_FORMAT("date_string_format", "Format to store and retrieve dates stored as text. Defaults to \"yyyy-MM-dd HH:mm:ss.SSS\"", null), | ||
DATE_STRING_FORMAT("date_string_format", "Format to store and retrieve dates stored as text. Defaults to \"yyyy-MM-dd\"", null), | ||
TIME_STRING_FORMAT("time_string_format", "Format to store and retrieve times stored as text. Defaults to \"HH:mm:ss\"", null), | ||
TIMESTAMP_STRING_FORMAT("timestamp_string_format", "Format to store and retrieve timestamps stored as text. Defaults to \"yyyy-MM-dd HH:mm:ss.SSS\"", null), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..and reuse them here?
No description provided.