Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "null" from type of JSONAPI prev/next #134

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Remove "null" from type of JSONAPI prev/next #134

merged 1 commit into from
Nov 2, 2017

Conversation

KronicDeth
Copy link
Contributor

Fixes #133

Test Report

Before

screen shot 2017-10-31 at 2 05 14 pm

After

screen shot 2017-10-31 at 2 10 04 pm

Changelog

Bug Fixes

  • Remove "null" from type of JSONAPI prev/next because SwaggerUI does not understand that type.

mbuhot
mbuhot approved these changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@mbuhot mbuhot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@mbuhot
Copy link
Contributor

mbuhot commented Nov 1, 2017

Looks like there's a failing test at test/json_api_test.exs:30

Once that is passing this should be good to merge.

@KronicDeth
Remove "null" from type of JSONAPI prev/next
ef30dbc 
SwaggerUI does not understand that type.
@KronicDeth
Copy link
Contributor Author

@mbuhot Test fixed and builds passed. Ready for merge.

@mbuhot mbuhot merged commit 242ca3f into xerions:master Nov 2, 2017
@KronicDeth KronicDeth deleted the 133 branch November 8, 2017 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbuhot mbuhot mbuhot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KronicDeth @mbuhot