Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESM support to Xerox CLI #833

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Add ESM support to Xerox CLI #833

merged 2 commits into from
Jul 27, 2021

Conversation

phawxby
Copy link
Contributor

@phawxby phawxby commented Jul 26, 2021

No description provided.

@phawxby phawxby requested a review from AndrewLeedham July 26, 2021 17:38
@AndrewLeedham
Copy link
Contributor

AndrewLeedham commented Jul 26, 2021

@phawxby My intention was to use https://github.com/davidtheclark/cosmiconfig at some-point, I just started with a simple require to see if the idea is viable or not. Perhaps now would be a good time to implement it?

@phawxby
Copy link
Contributor Author

phawxby commented Jul 26, 2021

Perhaps. My intention was just a quick fix to see if we can get ESM working as various modules used in BE are now upgraded in preparation for an actual ticket.

A proper upgrade of this module may take more time and testing should probably be ticketed too.

@AndrewLeedham
Copy link
Contributor

Perhaps. My intention was just a quick fix to see if we can get ESM working as various modules used in BE are now upgraded in preparation for an actual ticket.

A proper upgrade of this module may take more time and testing should probably be ticketed too.

Ok, can you resolve the vulnerability then, and we can get this merged.

@phawxby phawxby requested review from AndrewLeedham and removed request for AndrewLeedham July 27, 2021 13:09
@AndrewLeedham AndrewLeedham added approved change: feature Adds a new feature or improves on an existing one labels Jul 27, 2021
@AndrewLeedham AndrewLeedham changed the title feat: add ESM support Add ESM support to Xerox CLI Jul 27, 2021
@phawxby phawxby merged commit ab9d73e into next Jul 27, 2021
AndrewLeedham added a commit that referenced this pull request Jan 7, 2022
Add ESM support to Xerox CLI (#833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change: feature Adds a new feature or improves on an existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants