Update URL logic parsing to not force xethub.com as host #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoytak
commented
May 3, 2024
hoytak
commented
- Fixes bugs in parsing (parsing tests were never actually run)
- Tests now pass.
- Explicit domains are not forced to be xethub.com.
- Deprecation warnings given now.
added 4 commits
May 2, 2024 10:20
seanses
reviewed
May 6, 2024
| else: | ||
| raise ValueError(f"Cannot parse user and endpoint from {parse.netloc}") | ||
|
|
||
| if not parse.netloc.endswith(".com"): # Cheap way now to see if it's a website or not; we won't hit this with the old format. |
There was a problem hiding this comment.
What if we have a xethub.uw.edu deployment in the future, hmmm, just a guess
There was a problem hiding this comment.
This is only on the non-@ path with will be deprecated, so I'm not worried about future stuff. This is just to see if the start is xet://domain/user/... or xet://user/ You can break this by having a user that ends in .com, but I'm also not worried about that now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.