Basic support for browsing a specific version of a crate #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously pinned version of the time crate in Cargo.lock causes build errors in rustc 1.80.0. Bump to the next version to avoid the build failure.
this adds a couple of new path endpoints which can be used to browse the contents of a specific version of a crate. this is implemented under the hood as a diff between a crate/version and itself. When viewing one of these self-diffs, the folding logic is also modified to default to not folding unchanged hunks, as needing to expand every file while browsing is inconvenient.
mystor
added a commit
to mystor/cargo-vet
that referenced
this pull request
Sep 18, 2024
This change adds support to remember user's --mode choices, so that they do not need to be used every time. In addition, it adds a basic support for diff.rs to inspect (by loading a diff from a version to itself) such that this mode memory can be shared between diff and inspect. If xfbs/diff.rs#24 is merged, we should change the diff.rs inspect behaviour to use the new browse endpoints instead. Finally, this patch changes the default mode from sourcegraph to diff.rs. As noted in mozilla#611, sourcegraph has been quite unreliable lately, and diff.rs is likely to provide a better experience until that is resolved.
|
LGTM, thanks! |
mystor
added a commit
to mystor/cargo-vet
that referenced
this pull request
Sep 19, 2024
This was a new endpoint added in xfbs/diff.rs#24, which is used to browse a specific version of a crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of new path endpoints which can be used to browse the
contents of a specific version of a crate. this is implemented under the hood
as a diff between a crate/version and itself.
When viewing one of these self-diffs, the folding logic is also modified to
default to not folding unchanged hunks, as needing to expand every file while
browsing is inconvenient.