Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove srcset function in Image class #422

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Remove srcset function in Image class #422

merged 1 commit into from
Jun 28, 2019

Conversation

piotr-bajer
Copy link
Contributor

Currently, the srcset does the same as the parent version. Also, it has a bug because $size parameter is used anywhere.

@piotr-bajer
Remove srcset function
77b28f7 
Currently, the `srcset` does the same as the parent version. Also, it has a bug because `$size` parameter is used anywhere.
@piotr-bajer piotr-bajer mentioned this pull request Jun 25, 2019
Closed
@luboskmetko luboskmetko requested a review from JakubSzajna June 27, 2019 12:53
JakubSzajna
JakubSzajna approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@JakubSzajna JakubSzajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The srcset method wasn't in the Timber Image class initially, this is why we have it here. But it is now, so we can safely remove this from our code.

@luboskmetko luboskmetko merged commit e4f810e into xfiveco:master Jun 28, 2019
@piotr-bajer piotr-bajer deleted the patch-2 branch November 8, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakubSzajna JakubSzajna JakubSzajna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-bajer @JakubSzajna @luboskmetko