Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check user exists in AD then login or register him #103

Merged
merged 3 commits into from
Mar 9, 2022
Merged

feat: check user exists in AD then login or register him #103

merged 3 commits into from
Mar 9, 2022

Conversation

nunocaseiro
Copy link
Contributor

@nunocaseiro nunocaseiro commented Mar 7, 2022 •
edited
Loading

Relates to #102

Proposed Changes

  • Endpoint and respective method to check if the user exists in the active directory
  • Endpoint and respective method to check if the user can login or must first be registered in our database
  • Cronjob to get a azure access token to be able to make requests to microsoft graph services

This pull request is intended to close #102

@nunocaseiro nunocaseiro self-assigned this Mar 7, 2022
@nunocaseiro nunocaseiro marked this pull request as ready for review March 7, 2022 12:41
@nunocaseiro nunocaseiro force-pushed the feat-azure-sso branch 2 times, most recently from 18b4e05 to 63e9de5 Compare March 7, 2022 12:47
@nunocaseiro nunocaseiro requested a review from a team March 7, 2022 12:50
@nunocaseiro nunocaseiro changed the title feat: check users exists in AD then login or register user feat: check user exists in AD then login or register user Mar 7, 2022
@nunocaseiro nunocaseiro changed the title feat: check user exists in AD then login or register user feat: check user exists in AD then login or register him Mar 7, 2022
rpvsilva
rpvsilva requested changes Mar 8, 2022
View reviewed changes
Copy link
Member

@rpvsilva rpvsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes but you are rocking it 🚀

backend/src/modules/auth/shared/login.auth.ts Outdated Show resolved Hide resolved
backend/src/modules/azure/services/auth.azure.service.ts Outdated Show resolved Hide resolved
backend/src/modules/azure/services/auth.azure.service.ts Outdated Show resolved Hide resolved
backend/src/modules/azure/services/cron.azure.service.ts Outdated Show resolved Hide resolved
@nunocaseiro
Copy link
Contributor Author

Some small changes but you are rocking it 🚀

Thanks bro :)

@nunocaseiro nunocaseiro merged commit 982c42a into xgeekshq:main Mar 9, 2022
@nunocaseiro nunocaseiro deleted the feat-azure-sso branch November 18, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpvsilva rpvsilva rpvsilva approved these changes

Assignees

@nunocaseiro nunocaseiro

Labels
authentication backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Azure authentication (sso)
2 participants
@nunocaseiro @rpvsilva