Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: placeholder replaces card #1091

Merged
merged 2 commits into from
Feb 16, 2023
Merged

fix: placeholder replaces card #1091

merged 2 commits into from
Feb 16, 2023

Conversation

CatiaAntunes96
Copy link
Contributor

Fixes #1090

Proposed Changes

  • When editing a card, the textarea value is the text of the card and not the placeholder (previous behavior)
  • On a regular board, when the "default card text" is active, the placeholder also acts as value for the textarea
  • Fix toggle when user toggles the default car text button
  • Add team to UpdateBoardType's schema and pass team id field when updating a column position

This pull request closes #1090

@CatiaAntunes96 CatiaAntunes96 added bug Something isn't working frontend labels Feb 15, 2023
@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Feb 15, 2023
@CatiaAntunes96 CatiaAntunes96 self-assigned this Feb 15, 2023
@CatiaAntunes96 CatiaAntunes96 changed the title bug: placeholder replaces card fix: placeholder replaces card Feb 15, 2023
nunocaseiro
nunocaseiro approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@CatiaAntunes96 CatiaAntunes96 merged commit 764da08 into main Feb 16, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the bug/placeholder-replaces-card branch February 16, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[BUG]: placeholder replaces card text
2 participants
@CatiaAntunes96 @nunocaseiro