Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: textarea validation state #1097

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix: textarea validation state #1097

merged 1 commit into from
Feb 17, 2023

Conversation

jpvsalvador
Copy link
Contributor

Relates to #1096
Fixes #1096

Proposed Changes

  • Let the textarea primitive component decide for itself whether it has a state of error, valid or default based on the information provided by its form.

This pull request closes #1096

@jpvsalvador jpvsalvador added bug Something isn't working frontend labels Feb 17, 2023
@jpvsalvador jpvsalvador requested a review from a team February 17, 2023 10:22
@jpvsalvador jpvsalvador linked an issue Feb 17, 2023 that may be closed by this pull request
[BUG]: textarea validation state #1096
Closed
@jpvsalvador jpvsalvador self-assigned this Feb 17, 2023
@jpvsalvador jpvsalvador merged commit 1d5bb5d into main Feb 17, 2023
@jpvsalvador jpvsalvador deleted the 1096-bug-textarea-validation-state branch February 17, 2023 12:47
GoncaloCanteiro pushed a commit that referenced this pull request Feb 22, 2023
@jpvsalvador @GoncaloCanteiro
fix: textarea validation state (#1097)
39114d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@StereoPT StereoPT

@jpvsalvador jpvsalvador

Labels
bug Something isn't working frontend
Projects
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: textarea validation state
3 participants
@jpvsalvador @nunocaseiro @StereoPT