Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unique npm install and env files for all apps #111

Merged
merged 1 commit into from
Mar 18, 2022
Merged

chore: unique npm install and env files for all apps #111

merged 1 commit into from
Mar 18, 2022

Conversation

nunocaseiro
Copy link
Contributor

Proposed Changes

  • Workspaces in order to install all the dependecies on the root project folder
  • Configs updated to use the same env file for both apps
  • Docker files and workflows updated in order to use the same package-lock.json when the images are built

@nunocaseiro nunocaseiro marked this pull request as ready for review March 18, 2022 17:17
@nunocaseiro nunocaseiro requested a review from a team March 18, 2022 17:17
@nunocaseiro nunocaseiro merged commit bc11d27 into xgeekshq:main Mar 18, 2022
@nunocaseiro nunocaseiro deleted the chore-optimize-monorepo branch November 18, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serrovsky serrovsky serrovsky approved these changes

Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nunocaseiro @serrovsky