Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: persistent alert #116

Merged
merged 1 commit into from
Mar 30, 2022
Merged

feat: persistent alert #116

merged 1 commit into from
Mar 30, 2022

Conversation

JoelLInt
Copy link
Contributor

Relates to #115

Proposed Changes

  • Adapts based on the prop type ( warning or info);
  • Title is passed by prop and optional;
  • Text is passed by prop;

This pull request is intended to close #115

@JoelLInt JoelLInt force-pushed the feat-persistent-alerts branch from 3d5e88c to 0da7fee Compare March 30, 2022 10:01
@JoelLInt JoelLInt marked this pull request as ready for review March 30, 2022 10:02
@JoelLInt JoelLInt requested a review from a team March 30, 2022 10:03
nunocaseiro
nunocaseiro approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JoelLInt JoelLInt merged commit 9e38355 into main Mar 30, 2022
@nunocaseiro nunocaseiro deleted the feat-persistent-alerts branch May 3, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Primitive - Persistant alerts
2 participants
@JoelLInt @nunocaseiro