Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove server side props logic to a single request on backend #1169

Merged
merged 13 commits into from
Mar 2, 2023
Merged

refactor: remove server side props logic to a single request on backend #1169

merged 13 commits into from
Mar 2, 2023

Conversation

patricia-mdias
Copy link
Contributor

@patricia-mdias patricia-mdias commented Feb 28, 2023 •
edited
Loading

Fixes #1167

Proposed Changes

  • Change get board logic to backend
  • When user logs in as a non-guest user, remove guest user cookies
  • Super Admin isn't automatically added as a board user when accessing the board, since it is able to access all boards

This pull request closes #1167

@patricia-mdias patricia-mdias added this to the Full Version milestone Feb 28, 2023
@patricia-mdias patricia-mdias requested a review from a team February 28, 2023 16:38
@patricia-mdias patricia-mdias self-assigned this Feb 28, 2023
@patricia-mdias patricia-mdias changed the title Refactor/remove server side props logic to a single request on backend refactor: remove server side props logic to a single request on backend Feb 28, 2023
@patricia-mdias patricia-mdias marked this pull request as draft February 28, 2023 16:58
@patricia-mdias patricia-mdias marked this pull request as ready for review March 1, 2023 12:26
nunocaseiro
nunocaseiro requested changes Mar 1, 2023
View reviewed changes
backend/src/modules/boards/interfaces/services/create.board.user.service.interface.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.user.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.user.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/get.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/get.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/get.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/get.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/get.board.service.ts Outdated Show resolved Hide resolved
nunocaseiro
nunocaseiro approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 amazing job 🔥

@patricia-mdias patricia-mdias merged commit 509183d into main Mar 2, 2023
@patricia-mdias patricia-mdias deleted the refactor/remove-server-side-props-logic-to-a-single-request-on-backend branch March 2, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@patricia-mdias patricia-mdias

Labels
backend
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: remove server side props logic to a single request on backend
2 participants
@patricia-mdias @nunocaseiro