Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reset token and mailer #117

Merged
merged 11 commits into from
May 20, 2022
Merged

feat: reset token and mailer #117

merged 11 commits into from
May 20, 2022

Conversation

r-dmatos
Copy link
Contributor

@r-dmatos r-dmatos commented Apr 1, 2022 •
edited
Loading

Relates to #108

Proposed Changes

  • Reset token schema and create and update method implemented.
  • Mailer module was used to send an email with a link to reset the user password .
  • A 1 minute timer was implemented to the reset password flow to prevent extra requests from the same user ( there might be a better way to do this )
  • Env files updated with mailer module options

@r-dmatos r-dmatos force-pushed the feat-reset-token branch 3 times, most recently from e557202 to 2f1540c Compare April 6, 2022 18:51
@r-dmatos r-dmatos marked this pull request as ready for review April 13, 2022 10:13
@r-dmatos r-dmatos requested a review from a team April 13, 2022 10:13
@nunocaseiro
Copy link
Contributor

@all-contributors please add @r-dmatos for code and doc

@allcontributors allcontributors bot mentioned this pull request Apr 13, 2022
Merged
@allcontributors
Copy link
Contributor

@nunocaseiro

I've put up a pull request to add @r-dmatos! 🎉

@r-dmatos r-dmatos requested a review from rpvsilva April 27, 2022 13:29
nunocaseiro
nunocaseiro previously approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

rpvsilva
rpvsilva previously approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@rpvsilva rpvsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@r-dmatos r-dmatos dismissed stale reviews from rpvsilva and nunocaseiro via f952179 May 20, 2022 11:20
@r-dmatos r-dmatos requested a review from nunocaseiro May 20, 2022 12:46
@r-dmatos r-dmatos merged commit cdc5711 into main May 20, 2022
@nunocaseiro nunocaseiro deleted the feat-reset-token branch June 3, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

@rpvsilva rpvsilva rpvsilva left review comments

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-dmatos @nunocaseiro @rpvsilva