feat: add minimum time for the timer #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 9, 2023 18:48
…m-time-for-the-timer
…m-time-for-the-timer
geomarb
changed the title
geomarb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Proposed Changes
This PR turns the timer (
useTimer) more configurable. It is now possible to set up the following:START_MINUTES: (default value:5) default minutes for all timersSTART_SECONDS: (default value0) default minutes for all timersJUMP_SECONDS: (default value:5) increase/decrease seconds when setting the durationJUMP_MINUTES: (default value:1) increase/decrease minutes when setting the durationMIN_SECONDS: (default value:30) minimum seconds accepted when setting the durationMIN_MINUTES: (default value:0) minimum minuted accepted when setting the durationMAX_SECONDS: (default value:60 - JUMP_SECONDS) maximum seconds to set, it is related toJUMP_SECONDSin this case it will55seconds, ifJUMP_SECONDSis10it must be50and so on, otherwise it will be over60seconds.MAX_MINUTES: (default value:59) maximum minutes allowed for the timer if in any case, it needs to be greater than99the timer's design and its CSS must be changed as wellNote: The
loggerwas removed from theeventsin the backend, it actually should not be present in theeventssince if it is there it will be sent to the frontend inside the event.Note 2: The
previousStatuswas completely removed since wasn't necessary.This pull request closes: