Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: library mocks #1218

Merged
merged 4 commits into from
Mar 9, 2023
Merged

feat: library mocks #1218

merged 4 commits into from
Mar 9, 2023

Conversation

StereoPT
Copy link
Contributor

@StereoPT StereoPT commented Mar 9, 2023

Relates to:

Fixes:

Proposed Changes

  • Created a Library Mock, to mock both the React Query and the Next Router
  • Fixed all the tests that had their implementation of the Next Router Mock
  • Extracted the Wrapper to be able to use with the renderHook

This pull request closes:

@StereoPT StereoPT linked an issue Mar 9, 2023 that may be closed by this pull request
[FEATURE]: useTeam Hook Tests #1205
Closed
@StereoPT StereoPT requested a review from a team March 9, 2023 16:01
@StereoPT StereoPT assigned StereoPT and jpvsalvador and unassigned StereoPT Mar 9, 2023
nunocaseiro
nunocaseiro approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@StereoPT StereoPT merged commit f5f69f9 into main Mar 9, 2023
@StereoPT StereoPT deleted the 1205-feature-useteam-hook-tests branch March 9, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@StereoPT StereoPT

@jpvsalvador jpvsalvador

Labels
frontend tests
Projects
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: useTeam Hook Tests
3 participants
@StereoPT @nunocaseiro @jpvsalvador