Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: create team page refactor and tests #1226

Merged
merged 37 commits into from
Mar 13, 2023
Merged

test: create team page refactor and tests #1226

merged 37 commits into from
Mar 13, 2023

Conversation

jpvsalvador
Copy link
Contributor

Relates to:

Fixes:

Proposed Changes

  • Refactor Team Members list dialog and add tests for it
  • Refactor primitive and teams folder structure
  • Add missing tests for primitives

This pull request closes:

jpvsalvador and others added 30 commits March 6, 2023 16:55
@jpvsalvador
refactor: remove unnecessary ref
9477867
@jpvsalvador
Merge remote-tracking branch 'origin/main' into 1190-feature-create-t…
1539c7c 
…eam-page-refactor-and-tests
@jpvsalvador
refactor: group up alert dialog primitives
275058e
@jpvsalvador
refactor: normalize ListMembersDialog component
9e70e27
@jpvsalvador
fix: change alert dialog paths
bd53222
@jpvsalvador
test: add checkboxUserItem tests
3105580
@jpvsalvador
test: add userListDialog tests
018c667
@StereoPT
Merge branch 'main' into 1190-feature-create-team-page-refactor-and-t…
f15e9a3 
…ests
@StereoPT
refactor: alerts & avatars
c96ce8d
@StereoPT
refactor: breadcrumb
63e716a
@StereoPT
refactor: dialogs
68cd4f1
@StereoPT
refactor: inputs & loadings
da11255
@StereoPT
refactor: tooltip
a8442bf
@StereoPT
refactor: layout
74d80f0
@StereoPT
refactor: button
f8bd770
@StereoPT
refactor: switches & checkbox
4732787
@StereoPT
refactor: icon & svg
8703595
@StereoPT
refactor: input elements
362e9b0
@StereoPT
refactor: popover & toast
7696790
@StereoPT
refactor: text
363e9eb
@StereoPT
refactor: team list
5d07fea
@StereoPT
refactor: new joiner tooltip
1759750
@StereoPT
refactor: role selector & popover
f084281
@StereoPT
refactor: team folder
790f487
@StereoPT
refactor: create team
bca2ec8
@jpvsalvador
refactor: userCheckbox
05d9633
@jpvsalvador
refactor: primitive story paths
d84743f
@jpvsalvador
refactor: story locations
14d2491
@StereoPT
feat: coverage
3d6a8b8
@StereoPT
fix: coverage ignore stories
97786ab
@jpvsalvador jpvsalvador requested a review from a team March 13, 2023 10:16
@jpvsalvador jpvsalvador linked an issue Mar 13, 2023 that may be closed by this pull request
[FEATURE]: create team page refactor and tests #1190
Closed
@jpvsalvador jpvsalvador self-assigned this Mar 13, 2023
nunocaseiro
nunocaseiro requested changes Mar 13, 2023
View reviewed changes
frontend/src/components/Dashboard/Tiles/Tile/styles.tsx Outdated Show resolved Hide resolved
frontend/src/components/Dashboard/Tiles/Tile/styles.tsx Outdated Show resolved Hide resolved
frontend/src/components/Dashboard/Tiles/Tile/styles.tsx Outdated Show resolved Hide resolved
frontend/src/components/Primitives/Dialogs/UserListDialog/UserListDialog.tsx Outdated Show resolved Hide resolved
frontend/src/components/Primitives/Inputs/Checkboxes/Checkbox/Checkbox.tsx Outdated Show resolved Hide resolved
frontend/src/components/Primitives/Inputs/Checkboxes/Checkbox/Checkbox.tsx Outdated Show resolved Hide resolved
frontend/src/components/Primitives/Inputs/SearchInput/SearchInput.tsx Outdated Show resolved Hide resolved
frontend/src/components/Primitives/Popovers/TeamRolePopover/TeamRolePopover.tsx Outdated Show resolved Hide resolved
nunocaseiro
nunocaseiro approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 gj

@jpvsalvador jpvsalvador merged commit 8567423 into main Mar 13, 2023
@jpvsalvador jpvsalvador deleted the 1190-feature-create-team-page-refactor-and-tests branch March 13, 2023 12:18
GoncaloCanteiro pushed a commit that referenced this pull request Mar 13, 2023
@jpvsalvador @StereoPT @GoncaloCanteiro
test: create team page refactor and tests (#1226)
de07200 
Co-authored-by: Guido <stereopt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@StereoPT StereoPT

@jpvsalvador jpvsalvador

Labels
frontend tests
Projects
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: create team page refactor and tests
3 participants
@jpvsalvador @nunocaseiro @StereoPT