Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tipbar, header & footer #1236

Merged
merged 10 commits into from
Mar 14, 2023
Merged

feat: tipbar, header & footer #1236

merged 10 commits into from
Mar 14, 2023

Conversation

StereoPT
Copy link
Contributor

Relates to:

Fixes:

Screenshots (if visual changes)

image

image

image

Proposed Changes

  • Refactored the TipBar, the Header & Footer
  • Replaced duplicated components with these refactored ones.
  • Created Storybook & Tests for them
  • Removed Unused Styles

This pull request closes:

@StereoPT StereoPT requested a review from a team March 14, 2023 12:29
@StereoPT StereoPT self-assigned this Mar 14, 2023
@StereoPT StereoPT linked an issue Mar 14, 2023 that may be closed by this pull request
[FEATURE]: tipbar, header & footer refactor #1223
Closed
jpvsalvador
jpvsalvador approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@jpvsalvador jpvsalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@StereoPT StereoPT merged commit 0109034 into main Mar 14, 2023
@StereoPT StereoPT deleted the 1223-feature-tipbar-header-footer-refactor branch March 14, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpvsalvador jpvsalvador jpvsalvador approved these changes

Assignees

@StereoPT StereoPT

Labels
frontend tests
Projects
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: tipbar, header & footer refactor
2 participants
@StereoPT @jpvsalvador