Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: clean board #1240

Merged
merged 9 commits into from
Mar 17, 2023
Merged

test: clean board #1240

merged 9 commits into from
Mar 17, 2023

Conversation

CatiaAntunes96
Copy link
Contributor

Relates to:

Proposed Changes

  • Add tests to ensure that clean-board function is returning everything as it should, with different arguments

This pull request closes:

@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Mar 14, 2023
@CatiaAntunes96 CatiaAntunes96 self-assigned this Mar 14, 2023
@CatiaAntunes96 CatiaAntunes96 marked this pull request as draft March 16, 2023 12:57
@CatiaAntunes96 CatiaAntunes96 marked this pull request as ready for review March 16, 2023 14:29
nunocaseiro
nunocaseiro approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 great job

@CatiaAntunes96 CatiaAntunes96 merged commit 5ac840c into main Mar 17, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the test/clean-board branch March 17, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels
backend tests
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.
2 participants
@CatiaAntunes96 @nunocaseiro