Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve some code #127

Merged
merged 5 commits into from
Apr 11, 2022
Merged

chore: improve some code #127

merged 5 commits into from
Apr 11, 2022

Conversation

rpvsilva
Copy link
Member

Proposed Changes

  • Improved some logic
  • Instead of using an object on params just called ex: @param('socketId')
  • Made some spacing to be more readable
  • Removed some unnecessary variables

nunocaseiro
nunocaseiro approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rpvsilva rpvsilva merged commit bdc35f2 into xgeekshq:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpvsilva @nunocaseiro