Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create board service #1276

Merged
merged 12 commits into from
Mar 22, 2023
Merged

refactor: create board service #1276

merged 12 commits into from
Mar 22, 2023

Conversation

CatiaAntunes96
Copy link
Contributor

@CatiaAntunes96 CatiaAntunes96 commented Mar 20, 2023 •
edited
Loading

Relates to:

@patricia-mdias

Proposed Changes

  • Refactor of the code of create board service

@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Mar 20, 2023
@CatiaAntunes96 CatiaAntunes96 self-assigned this Mar 20, 2023
nunocaseiro
nunocaseiro requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the create board feature for all the cases just to figure out if all operations are still working? e.g. creating a regular and a split board. on the spit board, please test with the cron job if you haven't done so already

backend/src/libs/exceptions/createFailedBadRequestException.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
nunocaseiro
nunocaseiro approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@CatiaAntunes96 CatiaAntunes96 merged commit 4526fcf into main Mar 22, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the refactor/create-board-service branch March 22, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels
backend
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.
3 participants
@CatiaAntunes96 @nunocaseiro @patricia-mdias