Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: submitted action points format #1292

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix: submitted action points format #1292

merged 1 commit into from
Mar 22, 2023

Conversation

GoncaloCanteiro
Copy link
Contributor

Relates to:

Fixes:

  • The cards that have the "\n" doesn't stay aligned as points of a list
  • The cards with multiple "\n" have multiple new lines in the slack message

Screenshots (if visual changes)

image

image

Proposed Changes

  • Multiple \n are replaced with only one \n
  • After a \n it is introduced a \t for spacing and alignment

This pull request closes #1288

@GoncaloCanteiro
fix: submitted action points format
6cf777f 
  -When action points have multiple \n, it replaces them
  for one and does a \t in order to format the next line at the same
  distance.
@GoncaloCanteiro GoncaloCanteiro added bug Something isn't working backend labels Mar 22, 2023
@GoncaloCanteiro GoncaloCanteiro added this to the Full Version milestone Mar 22, 2023
@GoncaloCanteiro GoncaloCanteiro self-assigned this Mar 22, 2023
@GoncaloCanteiro GoncaloCanteiro linked an issue Mar 22, 2023 that may be closed by this pull request
[BUG]: submitted message with action points #1288
Closed
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 22, 2023 12:59
nunocaseiro
nunocaseiro approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GoncaloCanteiro GoncaloCanteiro merged commit 7074738 into main Mar 22, 2023
@GoncaloCanteiro GoncaloCanteiro deleted the bug/submitted-message-with-action-points branch March 22, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@GoncaloCanteiro GoncaloCanteiro

Labels
backend bug Something isn't working
Projects
SPLIT • Bugs
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[BUG]: submitted message with action points
2 participants
@GoncaloCanteiro @nunocaseiro