Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: create board service #1300

Merged
merged 5 commits into from
Mar 27, 2023
Merged

test: create board service #1300

merged 5 commits into from
Mar 27, 2023

Conversation

CatiaAntunes96
Copy link
Contributor

Relates to:

Proposed Changes

  • Refactor of the code on the create board service
  • Add tests of the create board service

This pull request closes #1227

@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Mar 23, 2023
@CatiaAntunes96 CatiaAntunes96 self-assigned this Mar 23, 2023
@CatiaAntunes96 CatiaAntunes96 changed the title Test: create board service test: create board service Mar 23, 2023
nunocaseiro
nunocaseiro requested changes Mar 26, 2023
View reviewed changes
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/create.board.service.ts Outdated Show resolved Hide resolved
nunocaseiro
nunocaseiro approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@CatiaAntunes96 CatiaAntunes96 merged commit ce0fd37 into main Mar 27, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the test/create-board-service branch March 27, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels
backend tests
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[TEST]: create board service
2 participants
@CatiaAntunes96 @nunocaseiro