Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: mergecardservice to usecase #1309

Merged
merged 20 commits into from
Mar 28, 2023
Merged

refactor: mergecardservice to usecase #1309

merged 20 commits into from
Mar 28, 2023

Conversation

GoncaloCanteiro
Copy link
Contributor

Relates to:

Proposed Changes

  • Create useCase for merge Card
  • Delete merge card service

This pull request closes #1308

GoncaloCanteiro and others added 17 commits March 22, 2023 16:20
@GoncaloCanteiro
refactor: exception insert_failed to service
6fac1c1
@GoncaloCanteiro
refactor: create card service to useCase
3954880 
  - create dto for createCardUseCase response and parameters
  - transfer service logic to useCase
@GoncaloCanteiro
fix: createCardUseCase name, add provider/module
26e541b
@GoncaloCanteiro
fix: remove create.card.service
ac92c1a
@GoncaloCanteiro
test: create-card useCase base test
c41559e
@GoncaloCanteiro
refactor: create-card useCase into functions
08adcb8
@GoncaloCanteiro
refactor: getNewCardPopulated name, add try catch
96f4de2
@GoncaloCanteiro
test: completed test coverage
a537ce7 
  -Add tests for error handling
  -Add test to verify if card is hidden
  -Add test to verify if card is not hidden
  -Add test to verify if return a card if doest have items
@GoncaloCanteiro
Merge branch 'main' into refactor/create-card-service-to-usecase
e35f3f3
@GoncaloCanteiro
fix: change dto to presenter, delete params folder
91ea102
@GoncaloCanteiro
feat: add merge-card.use-case dto
a6c0135
@GoncaloCanteiro
fix: isString validator
1330293
@GoncaloCanteiro
refactor: merge.card.service to useCase
60f9cb2
@GoncaloCanteiro
fix: remove unused merge.service and merge.app
0c364d3
@GoncaloCanteiro
test: add merge-card.use-case
f9709fe
@GoncaloCanteiro
fix: missing await in controller
4c0475b
@GoncaloCanteiro
refactor: concatenate cards to a funtion
9b82a83
@GoncaloCanteiro GoncaloCanteiro added this to the Full Version milestone Mar 27, 2023
@GoncaloCanteiro GoncaloCanteiro self-assigned this Mar 27, 2023
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 27, 2023 16:30
@GoncaloCanteiro GoncaloCanteiro marked this pull request as draft March 28, 2023 08:23
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 28, 2023 08:36
nunocaseiro
nunocaseiro approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GoncaloCanteiro GoncaloCanteiro merged commit e35180a into main Mar 28, 2023
@GoncaloCanteiro GoncaloCanteiro deleted the refactor/mergecardservice-to-usecase branch March 28, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@GoncaloCanteiro GoncaloCanteiro

Labels
backend enhancement New feature or request tests
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: merge.card.service to useCase
2 participants
@GoncaloCanteiro @nunocaseiro