Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: unmergecardservice to usecase and tests #1312

Merged
merged 12 commits into from
Mar 29, 2023
Merged

refactor: unmergecardservice to usecase and tests #1312

merged 12 commits into from
Mar 29, 2023

Conversation

GoncaloCanteiro
Copy link
Contributor

Relates to:

Proposed Changes

  • Create unmerge.card useCase
  • Remove unmerge.card service

This pull request closes #1310

@GoncaloCanteiro GoncaloCanteiro added this to the Full Version milestone Mar 29, 2023
@GoncaloCanteiro GoncaloCanteiro self-assigned this Mar 29, 2023
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 29, 2023 09:59
@GoncaloCanteiro GoncaloCanteiro changed the title refactor: unmergecardservice to usecase refactor: unmergecardservice to usecase and tests Mar 29, 2023
nunocaseiro
nunocaseiro approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GoncaloCanteiro GoncaloCanteiro merged commit aa202d9 into main Mar 29, 2023
@GoncaloCanteiro GoncaloCanteiro deleted the refactor/unmergecardservice-to-usecase branch March 29, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@GoncaloCanteiro GoncaloCanteiro

Labels
backend enhancement New feature or request tests
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: unmerge.card.service to useCase
2 participants
@GoncaloCanteiro @nunocaseiro