Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add auth page reponsiveness #1367

Merged
merged 8 commits into from
Apr 6, 2023
Merged

feat: add auth page reponsiveness #1367

merged 8 commits into from
Apr 6, 2023

Conversation

juniorboos
Copy link
Contributor

@juniorboos juniorboos commented Apr 5, 2023 •
edited
Loading

Relates to:

Screenshots (if visual changes)

Old New
image image
image image
image image

Proposed Changes

  • Changed the ImageContainer CSS to include flex-grow: 1 instead of the FormContainer, so it can be dynamic depending on the viewport.
  • Replaced some of the hardcoded values with theme tokens.
  • Fixed unnecessary horizontal scroll on smaller screens.

Note: I recommend running this locally to avoid unexpected behaviours

@juniorboos juniorboos marked this pull request as ready for review April 5, 2023 17:52
@juniorboos juniorboos marked this pull request as draft April 6, 2023 08:47
@juniorboos juniorboos self-assigned this Apr 6, 2023
@juniorboos juniorboos marked this pull request as ready for review April 6, 2023 09:19
CatiaBarroco-xgeeks
CatiaBarroco-xgeeks approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@juniorboos juniorboos requested a review from StereoPT April 6, 2023 09:26
StereoPT
StereoPT approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@StereoPT StereoPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM 🗝️

frontend/src/components/layouts/AccessLayout/styles.tsx Outdated Show resolved Hide resolved
@juniorboos juniorboos merged commit 67ee055 into main Apr 6, 2023
@juniorboos juniorboos deleted the refactor/fix-auth-responsiveness branch April 6, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks CatiaBarroco-xgeeks approved these changes

@StereoPT StereoPT StereoPT approved these changes

@nunocaseiro nunocaseiro Awaiting requested review from nunocaseiro

Assignees

@juniorboos juniorboos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juniorboos @StereoPT @CatiaBarroco-xgeeks