Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change type for constants on team module #1401

Merged
merged 3 commits into from
Apr 17, 2023
Merged

refactor: change type for constants on team module #1401

merged 3 commits into from
Apr 17, 2023

Conversation

CatiaAntunes96
Copy link
Contributor

Relates to:

Proposed Changes

  • Change types file name to constants and remove it from the directory interfaces
  • Change export object to constants. This way, we avoid the import of everything that it's in the file

@CatiaAntunes96 CatiaAntunes96 self-assigned this Apr 14, 2023
@CatiaAntunes96 CatiaAntunes96 added enhancement New feature or request backend labels Apr 14, 2023
@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Apr 14, 2023
@CatiaAntunes96 CatiaAntunes96 removed the enhancement New feature or request label Apr 14, 2023
@CatiaAntunes96 CatiaAntunes96 merged commit 5a54818 into main Apr 17, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the refactor/change-team-module-types-for-constants branch April 17, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

@rpvsilva rpvsilva Awaiting requested review from rpvsilva

@dsousa12 dsousa12 Awaiting requested review from dsousa12

@tutods tutods Awaiting requested review from tutods

@RubenMCCarreira RubenMCCarreira Awaiting requested review from RubenMCCarreira

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels
backend
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.
2 participants
@CatiaAntunes96 @nunocaseiro