Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add board card responsiveness #1425

Merged
merged 9 commits into from
Apr 26, 2023

Conversation

juniorboos
Copy link
Contributor

@juniorboos juniorboos commented Apr 21, 2023

Relates to:

Screenshots (if visual changes)

Old New
image image
image image
image image

Proposed Changes

  • Minor fix to Sidebar height after updating the Button.
  • Decreased layout's padding on smaller screens.
  • Added responsiveness to LeftArrow
    • Moved component to SubBoards, as it can receive a isLast prop to render or not a vertical bar.
    • Replaced the line_long icon with a div, as it can be responsive in height.
    • Added a div that acts as a vertical bar that connects to the next card.
  • Refactored SubBoards logic to use filter instead of conditional rendering.
  • Refactored CountCards HTML so it doesn't separate the numbers from the label.
  • Refactored CenterMainBoard to use Button instead of a div to collapse the sub-boards.
  • Refactored CardBody and CardEnd to support wrapping.

Note: I noticed that this PR became bigger than I expected, so I can split this in 2 if needed.

@juniorboos juniorboos marked this pull request as ready for review April 21, 2023 16:17
@juniorboos juniorboos requested review from nunocaseiro, jpvsalvador, tutods and a team April 21, 2023 16:22
@juniorboos juniorboos self-assigned this Apr 24, 2023
Copy link
Contributor

@tutods tutods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juniorboos juniorboos merged commit ecd2b93 into main Apr 26, 2023
@juniorboos juniorboos deleted the feat/add-board-card-responsiveness branch April 26, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants