Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change types for constants on communication module #1440

Merged
merged 3 commits into from
Apr 28, 2023
Merged

refactor: change types for constants on communication module #1440

merged 3 commits into from
Apr 28, 2023

Conversation

CatiaAntunes96
Copy link
Contributor

Relates to:

Proposed Changes

  • Change types for constants on communication module

@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Apr 27, 2023
@CatiaAntunes96 CatiaAntunes96 self-assigned this Apr 27, 2023
GoncaloCanteiro
GoncaloCanteiro approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@GoncaloCanteiro GoncaloCanteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 👍

@CatiaAntunes96 CatiaAntunes96 merged commit 7553842 into main Apr 28, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the refactor/change-communication-module-types-for-constants branch April 28, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoncaloCanteiro GoncaloCanteiro GoncaloCanteiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels
backend
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.
2 participants
@CatiaAntunes96 @GoncaloCanteiro